fix: preserve empty projection when ser/de HashJoinExec and NestedLoopJoinExec#23082
Open
haohuaijin wants to merge 3 commits into
Open
fix: preserve empty projection when ser/de HashJoinExec and NestedLoopJoinExec#23082haohuaijin wants to merge 3 commits into
HashJoinExec and NestedLoopJoinExec#23082haohuaijin wants to merge 3 commits into
Conversation
alamb
approved these changes
Jun 23, 2026
alamb
left a comment
Contributor
There was a problem hiding this comment.
Makes sense to me -- thanks @haohuaijin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
HashJoinExec/NestedLoopJoinExecprojectionSome(vec![])becomesNoneafter ser/de #23083Rationale for this change
HashJoinExecandNestedLoopJoinExeccarryprojection: Option<Vec<usize>>but the proto field isrepeated uint32. Proto3 can't tellNonefromSome(vec![]), and the decoder treats both asNone.Some(vec![])is reachable in real plans —try_embed_projectionproduces it forSELECT count(1) … JOIN …(#20191) — and after a round-trip the join silently switches from "emit zero columns" to "emit all columns".FilterExechas a workaround for the same limitation; these two execs were missed.What changes are included in this PR?
Encode
Some(vec![])as the single-element sentinel[u32::MAX](never a valid column index); recognise it on decode. Everything else goes through unchanged.Applied symmetrically to
HashJoinExecandNestedLoopJoinExec.Are these changes tested?
yes, add roundtrip test case
Are there any user-facing changes?